Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: ui/views/widget/native_widget_mac.mm

Issue 982193003: MacViews: Emit NOTIMPLEMENTED() in NativeWidgetMac::ViewRemoved() only when potentially dragging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150129-MacViews-Bringup5
Patch Set: rebase; emit when mouse button donw Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/widget/native_widget_mac.mm
diff --git a/ui/views/widget/native_widget_mac.mm b/ui/views/widget/native_widget_mac.mm
index a9af6fe6d67fb2e632b905e14619ccc86540617f..04adf3012019ab467cb14515ffb005afa6fc76a1 100644
--- a/ui/views/widget/native_widget_mac.mm
+++ b/ui/views/widget/native_widget_mac.mm
@@ -194,7 +194,11 @@ void NativeWidgetMac::ReorderNativeViews() {
}
void NativeWidgetMac::ViewRemoved(View* view) {
- NOTIMPLEMENTED();
+ // TODO(tapted): Something for drag and drop might be needed here in future.
+ // See http://crbug.com/464581. A NOTIMPLEMENTED() here makes a lot of spam,
+ // so only emit it when a drag and drop could be likely.
+ if (IsMouseButtonDown())
+ NOTIMPLEMENTED();
}
void NativeWidgetMac::SetNativeWindowProperty(const char* name, void* value) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698