Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 982193003: MacViews: Emit NOTIMPLEMENTED() in NativeWidgetMac::ViewRemoved() only when potentially dragging (Closed)

Created:
5 years, 9 months ago by tapted
Modified:
5 years ago
Reviewers:
jackhou1
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150129-MacViews-Bringup5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Emit NOTIMPLEMENTED() in NativeWidgetMac::ViewRemoved() only when potentially dragging This currently generates a lot of log spam. Aura widgets do something for drag and drop here, but that's coming later. By continuing to emit the log when a mouse button is pressed, the log may still hint at the potential cause of an imminent problem. BUG=464581, 565979 Committed: https://crrev.com/c021d09a56a7031ad33a592285b9d033f383425d Cr-Commit-Position: refs/heads/master@{#364509}

Patch Set 1 #

Patch Set 2 : rebase; emit when mouse button donw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/views/widget/native_widget_mac.mm View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
tapted
Hi Jack, please take a look
5 years ago (2015-12-10 05:43:32 UTC) #4
jackhou1
lgtm
5 years ago (2015-12-10 22:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/982193003/20001
5 years ago (2015-12-10 22:29:53 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-10 22:39:33 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-10 22:40:39 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c021d09a56a7031ad33a592285b9d033f383425d
Cr-Commit-Position: refs/heads/master@{#364509}

Powered by Google App Engine
This is Rietveld 408576698