Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 982153003: [parser] better error message for generator constructors (Closed)

Created:
5 years, 9 months ago by caitp (gmail)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] better error message for generator constructors BUG= LOG=N R=arv@chromium.org Committed: https://crrev.com/9e482baf81d9c742be48b30cde8a55c5a17f2b0a Cr-Commit-Position: refs/heads/master@{#27051}

Patch Set 1 #

Patch Set 2 : Added message tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M src/messages.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/preparser.h View 1 chunk +3 lines, -1 line 0 comments Download
A + test/message/class-constructor-accessor.js View 1 1 chunk +1 line, -5 lines 0 comments Download
A test/message/class-constructor-accessor.out View 1 1 chunk +7 lines, -0 lines 0 comments Download
A + test/message/class-constructor-generator.js View 1 1 chunk +1 line, -5 lines 0 comments Download
A + test/message/class-constructor-generator.out View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
caitp (gmail)
I dunno if anyone has an opinion on this, but I think it's weird to ...
5 years, 9 months ago (2015-03-05 23:25:57 UTC) #1
arv (Not doing code reviews)
On 2015/03/05 23:25:57, caitp wrote: > I dunno if anyone has an opinion on this, ...
5 years, 9 months ago (2015-03-06 10:01:06 UTC) #2
caitp (gmail)
On 2015/03/06 10:01:06, arv wrote: > On 2015/03/05 23:25:57, caitp wrote: > > I dunno ...
5 years, 9 months ago (2015-03-06 14:47:49 UTC) #3
arv (Not doing code reviews)
LGTM
5 years, 9 months ago (2015-03-06 16:19:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982153003/20001
5 years, 9 months ago (2015-03-06 16:25:06 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 16:54:38 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 16:54:50 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9e482baf81d9c742be48b30cde8a55c5a17f2b0a
Cr-Commit-Position: refs/heads/master@{#27051}

Powered by Google App Engine
This is Rietveld 408576698