Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Issue 982143002: Revert of Simplify and compact transitions storage (Closed)

Created:
5 years, 9 months ago by Jakob Kummerow
Modified:
5 years, 9 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-dev, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Simplify and compact transitions storage (patchset #4 id:80001 of https://codereview.chromium.org/980573002/) Reason for revert: x64 test failures Original issue's description: > Simplify and compact transitions storage > > Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. > To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. > > Committed: https://crrev.com/45fbef7f2252fce10634931cb103ccc1fc95ae6a > Cr-Commit-Position: refs/heads/master@{#27029} TBR=verwaest@chromium.org,ulan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/948a973d458002cd3a66c14fb8635cb3256dc4b2 Cr-Commit-Position: refs/heads/master@{#27030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1057 lines, -1036 lines) Patch
M src/heap-snapshot-generator.cc View 1 chunk +13 lines, -16 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 8 chunks +29 lines, -49 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 2 chunks +17 lines, -10 lines 0 comments Download
M src/hydrogen.h View 1 chunk +3 lines, -4 lines 0 comments Download
M src/json-parser.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.h View 8 chunks +84 lines, -9 lines 0 comments Download
M src/objects.cc View 27 chunks +199 lines, -97 lines 0 comments Download
M src/objects-debug.cc View 3 chunks +8 lines, -19 lines 0 comments Download
M src/objects-inl.h View 6 chunks +173 lines, -12 lines 0 comments Download
M src/objects-printer.cc View 5 chunks +17 lines, -21 lines 0 comments Download
M src/transitions.h View 4 chunks +139 lines, -190 lines 0 comments Download
M src/transitions.cc View 3 chunks +150 lines, -439 lines 0 comments Download
M src/transitions-inl.h View 3 chunks +93 lines, -28 lines 0 comments Download
M test/cctest/test-heap.cc View 6 chunks +8 lines, -15 lines 0 comments Download
M test/cctest/test-migrations.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M test/cctest/test-transitions.cc View 10 chunks +106 lines, -107 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
Created Revert of Simplify and compact transitions storage
5 years, 9 months ago (2015-03-05 20:39:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982143002/1
5 years, 9 months ago (2015-03-05 20:41:35 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 20:41:56 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/948a973d458002cd3a66c14fb8635cb3256dc4b2 Cr-Commit-Position: refs/heads/master@{#27030}
5 years, 9 months ago (2015-03-05 20:42:11 UTC) #4
Jakob Kummerow
5 years, 9 months ago (2015-03-06 12:33:48 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/988703002/ by jkummerow@chromium.org.

The reason for reverting is: reland.

Powered by Google App Engine
This is Rietveld 408576698