Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 98213003: Files.app: Remove the ButterBar class. (Closed)

Created:
7 years ago by hirono
Modified:
7 years ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Remove the ButterBar class. BatterBar is replaced with new ProgressCenter class. This is no longer needed. This CL removes the ButterBar class, HTML elements and CSS styles. BUG=318931 TEST=manually R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -450 lines) Patch
M chrome/browser/resources/file_manager/foreground/css/file_manager.css View 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/resources/file_manager/foreground/js/butter_bar.js View 1 chunk +0 lines, -360 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/file_manager.js View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/main_scripts.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/foreground/js/ui/progress_center_panel.js View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/file_manager/main.html View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thanks!
7 years ago (2013-12-02 08:41:49 UTC) #1
yoshiki
lgtm
7 years ago (2013-12-03 02:44:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/98213003/1
7 years ago (2013-12-03 02:56:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195906
7 years ago (2013-12-03 05:43:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/98213003/1
7 years ago (2013-12-03 06:29:20 UTC) #5
hirono
7 years ago (2013-12-03 10:24:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r238333 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698