Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 98213002: Don't show the bubble during auto-translating except for the first time (Closed)

Created:
7 years ago by hajimehoshi
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Don't show the bubble during auto-translating except for the first time BUG=324169 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238322

Patch Set 1 #

Patch Set 2 : rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/ui/views/translate/translate_bubble_view.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hajimehoshi
Can you take a look? Thank you in advance.
7 years ago (2013-12-02 04:16:51 UTC) #1
sky
LGTM
7 years ago (2013-12-02 21:42:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/98213002/20001
7 years ago (2013-12-03 03:05:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=195905
7 years ago (2013-12-03 05:44:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/98213002/20001
7 years ago (2013-12-03 05:47:34 UTC) #5
commit-bot: I haz the power
7 years ago (2013-12-03 08:03:29 UTC) #6
Message was sent while issue was closed.
Change committed as 238322

Powered by Google App Engine
This is Rietveld 408576698