Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 982113002: Fix a bug in UserScriptLoader. (Closed)

Created:
5 years, 9 months ago by Xi Han
Modified:
5 years, 9 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in UserScriptLoader. 1. Fix a misuse of a released pointer in UserScriptLoader; 2. Add initilaztions for the variables that will be picked in UserScript. BUG=461052 Committed: https://crrev.com/0237e7bb40c9ce7b194564c8c7815521b17a30b1 Cr-Commit-Position: refs/heads/master@{#319329}

Patch Set 1 : #

Total comments: 3

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M extensions/browser/user_script_loader.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M extensions/common/host_id.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/user_script.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Xi Han
Hi Devlin, a simple patch that fixes a bug in UserScriptLoader. PTAL, thanks!
5 years, 9 months ago (2015-03-05 20:13:48 UTC) #3
Devlin
lgtm https://codereview.chromium.org/982113002/diff/20001/extensions/browser/user_script_loader.cc File extensions/browser/user_script_loader.cc (right): https://codereview.chromium.org/982113002/diff/20001/extensions/browser/user_script_loader.cc#newcode450 extensions/browser/user_script_loader.cc:450: if (user_scripts_ && !user_scripts_->empty() && D'oh. https://codereview.chromium.org/982113002/diff/20001/extensions/common/user_script.cc File ...
5 years, 9 months ago (2015-03-05 20:18:38 UTC) #4
Xi Han
https://codereview.chromium.org/982113002/diff/20001/extensions/common/user_script.cc File extensions/common/user_script.cc (right): https://codereview.chromium.org/982113002/diff/20001/extensions/common/user_script.cc#newcode84 extensions/common/user_script.cc:84: host_id_(HostID()), On 2015/03/05 20:18:38, Devlin wrote: > Default constructors ...
5 years, 9 months ago (2015-03-05 20:26:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982113002/40001
5 years, 9 months ago (2015-03-05 20:27:35 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-05 21:26:15 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 21:26:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0237e7bb40c9ce7b194564c8c7815521b17a30b1
Cr-Commit-Position: refs/heads/master@{#319329}

Powered by Google App Engine
This is Rietveld 408576698