Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 982083004: Add gpu_perftests_apk transitive dependencies to all. (Closed)

Created:
5 years, 9 months ago by Daniele Castagna
Modified:
5 years, 9 months ago
Reviewers:
shatch, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add gpu_perftests_apk transitive dependencies to all. Make sure that gpu_perftests_apk gets built when ninja is run without specifying a target. BUG=464373 Committed: https://crrev.com/20e3f0f204923504335bc0508154f853e4b81c16 Cr-Commit-Position: refs/heads/master@{#319379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
shatch
On 2015/03/05 20:05:14, Daniele Castagna wrote: > mailto:dcastagna@chromium.org changed reviewers: > + mailto:simonhatch@chromium.org lg2m
5 years, 9 months ago (2015-03-05 20:09:35 UTC) #2
Daniele Castagna
+thakis for owner approval.
5 years, 9 months ago (2015-03-05 20:50:59 UTC) #4
Nico
This shouldn't make a difference. build/all.gyp already references gpu.gyp, and calling ninja without arguments should ...
5 years, 9 months ago (2015-03-05 23:52:44 UTC) #5
Nico
Hm, doesn't look like what I said is true. This is probably a good change, ...
5 years, 9 months ago (2015-03-06 00:04:09 UTC) #6
Nico
ok, lgtm. Sorry about being confused.
5 years, 9 months ago (2015-03-06 00:10:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/982083004/1
5 years, 9 months ago (2015-03-06 00:16:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 00:51:04 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 00:51:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20e3f0f204923504335bc0508154f853e4b81c16
Cr-Commit-Position: refs/heads/master@{#319379}

Powered by Google App Engine
This is Rietveld 408576698