Issue 98193002: Call convertToLength in CSSToStyleMap instead of having it inlined

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98193002: Call convertToLength in CSSToStyleMap instead of having it inlined (Closed)

Created:
7 years ago by Timothy Loh

Modified:
7 years ago

Reviewers:
dstockwell, alancutter (OOO until 2018)

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Call convertToLength in CSSToStyleMap instead of having it inlined Trivial cleanup; reduce copy-paste in CSSToStyleMap. Note that the case where the primitive value isn't an appropriate type shouldn't occur since we generally assume the parser only allows valid types through so we change it to an assertion here. BUG=322365 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162958

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -22 lines)			Patch
	M	Source/core/css/resolver/CSSToStyleMap.cpp	View		2 chunks	+4 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/98193002/1

7 years ago (2013-12-02 04:20:51 UTC) #3

Message was sent while issue was closed.

Change committed as 162958

Expand Messages | Collapse Messages