Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 981923002: IDL: Propagate parser errors occurred in InterfaceMembers (Closed)

Created:
5 years, 9 months ago by bashi
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IDL: Propagate parser errors occurred in InterfaceMembers Otherwise, the IDL compiler goes into an infinite loop when an IDL file contains unresolved diffs. BUG=460811 Committed: https://crrev.com/4b657270fe823b2d26e6d1883afe06eda03a2369 Cr-Commit-Position: refs/heads/master@{#319394}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M tools/idl_parser/idl_parser.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/idl_parser/test_parser/interface_web.idl View 1 chunk +17 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
bashi
PTAL? https://codereview.chromium.org/981923002/diff/1/tools/idl_parser/test_parser/interface_web.idl File tools/idl_parser/test_parser/interface_web.idl (right): https://codereview.chromium.org/981923002/diff/1/tools/idl_parser/test_parser/interface_web.idl#newcode84 tools/idl_parser/test_parser/interface_web.idl:84: <<<<<< ours I use '<<<<<<' instead of '<<<<<<<' ...
5 years, 9 months ago (2015-03-06 01:06:04 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-06 02:30:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981923002/1
5 years, 9 months ago (2015-03-06 02:35:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 02:39:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 02:40:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4b657270fe823b2d26e6d1883afe06eda03a2369
Cr-Commit-Position: refs/heads/master@{#319394}

Powered by Google App Engine
This is Rietveld 408576698