Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: Source/core/html/canvas/WebGL2RenderingContextBase.h

Issue 981913002: update getFramebufferAttachmentParameter for WebGL 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: addressed zmo@'s feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/canvas/WebGL2RenderingContextBase.h
diff --git a/Source/core/html/canvas/WebGL2RenderingContextBase.h b/Source/core/html/canvas/WebGL2RenderingContextBase.h
index bbcc8de66f29ef2be8bd9d36b89814b928a6cd1d..dd81769b1964c2e4074820567e07607fe2763c55 100644
--- a/Source/core/html/canvas/WebGL2RenderingContextBase.h
+++ b/Source/core/html/canvas/WebGL2RenderingContextBase.h
@@ -161,11 +161,17 @@ public:
DECLARE_VIRTUAL_TRACE();
+ ScriptValue getFramebufferAttachmentParameter(ScriptState*, GLenum target, GLenum attachment, GLenum pname) override;
+
protected:
WebGL2RenderingContextBase(HTMLCanvasElement*, PassOwnPtr<blink::WebGraphicsContext3D>, const WebGLContextAttributes& requestedAttributes);
bool validateClearBuffer(const char* functionName, GLenum buffer, GLsizei length);
+ // Helper function to validate target and the attachment combination for getFramebufferAttachmentParameters.
+ // Generate GL error and return false if parameters are illegal.
+ bool validateGetFramebufferAttachmentParameterFunc(const char* functionName, GLenum target, GLenum attachment);
+
/* WebGLRenderingContextBase overrides */
bool validateCapability(const char* functionName, GLenum) override;
bool validateAndUpdateBufferBindTarget(const char* functionName, GLenum, WebGLBuffer*) override;

Powered by Google App Engine
This is Rietveld 408576698