Source/platform/graphics/gpu/DrawingBuffer.h - Issue 981913002: update getFramebufferAttachmentParameter for WebGL 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/gpu/DrawingBuffer.h

Issue 981913002: update getFramebufferAttachmentParameter for WebGL 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr@'s feedback: get the 'correct' framebuffer bound to the given target Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGLRenderingContextBase.cpp ('K') | « Source/core/html/canvas/WebGLRenderingContextBase.cpp ('k') | Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/gpu/DrawingBuffer.h

diff --git a/Source/platform/graphics/gpu/DrawingBuffer.h b/Source/platform/graphics/gpu/DrawingBuffer.h

index d2531168184b3acb2b53f3d106097debe43f2abf..81c98223027a66456c277fb06c4bb9284ae22c54 100644

--- a/Source/platform/graphics/gpu/DrawingBuffer.h

+++ b/Source/platform/graphics/gpu/DrawingBuffer.h

@@ -106,7 +106,7 @@ public:

// Given the desired buffer size, provides the largest dimensions that will fit in the pixel budget.

static IntSize adjustSize(const IntSize& desiredSize, const IntSize& curSize, int maxTextureSize);

bool reset(const IntSize&);

- void bind();

+ void bind(GLenum target = GL_FRAMEBUFFER);

IntSize size() const { return m_size; }

// Copies the multisample color buffer to the normal color buffer and leaves m_fbo bound.