Source/core/html/canvas/WebGLRenderingContextBase.h - Issue 981913002: update getFramebufferAttachmentParameter for WebGL 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLRenderingContextBase.h

Issue 981913002: update getFramebufferAttachmentParameter for WebGL 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed kbr@'s feedback: get the 'correct' framebuffer bound to the given target Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('K') | « Source/core/html/canvas/WebGL2RenderingContextBase.cpp ('k') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGLRenderingContextBase.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/canvas/WebGLRenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGLRenderingContextBase.h b/Source/core/html/canvas/WebGLRenderingContextBase.h

index f634712035debb45f58f275039dc38d558412c07..59aa36c7d8834637ab830eb9e1ff2c96b09d9723 100644

--- a/Source/core/html/canvas/WebGLRenderingContextBase.h

+++ b/Source/core/html/canvas/WebGLRenderingContextBase.h

@@ -202,7 +202,7 @@ public:

void getContextAttributes(Nullable<WebGLContextAttributes>&);

GLenum getError();

ScriptValue getExtension(ScriptState*, const String& name);

- ScriptValue getFramebufferAttachmentParameter(ScriptState*, GLenum target, GLenum attachment, GLenum pname);

+ virtual ScriptValue getFramebufferAttachmentParameter(ScriptState*, GLenum target, GLenum attachment, GLenum pname);

virtual ScriptValue getParameter(ScriptState*, GLenum pname);

ScriptValue getProgramParameter(ScriptState*, WebGLProgram*, GLenum pname);

String getProgramInfoLog(WebGLProgram*);