Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 981843003: Printing: PDFs should only be fit to page if there is a size mismatch. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez, raymes
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, bradnelson+warch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf169120
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Printing: PDFs should only be fit to page if there is a size mismatch. BUG=158752 Committed: https://crrev.com/957b445184639d1c6d141a6eca7bed8c89b142de Cr-Commit-Position: refs/heads/master@{#320167}

Patch Set 1 : #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : address comment #

Patch Set 5 : rebase #

Patch Set 6 : fix win #

Total comments: 4

Patch Set 7 : nit #

Patch Set 8 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -23 lines) Patch
M components/printing/renderer/print_web_view_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 2 3 4 5 6 10 chunks +49 lines, -18 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M pdf/instance.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M pdf/pdf_engine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M ppapi/c/private/ppp_pdf.h View 1 chunk +7 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Lei Zhang
This builds on top of https://codereview.chromium.org/974183003/ which is in CQ, and requires https://codereview.chromium.org/980733002/ on the ...
5 years, 9 months ago (2015-03-05 19:24:18 UTC) #4
raymes
lgtm https://codereview.chromium.org/981843003/diff/60001/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (right): https://codereview.chromium.org/981843003/diff/60001/pdf/out_of_process_instance.cc#newcode612 pdf/out_of_process_instance.cc:612: options->uniform_page_size = PP_Size(uniform_page_size); is this a cast? Can ...
5 years, 9 months ago (2015-03-09 00:12:32 UTC) #5
Lei Zhang
https://codereview.chromium.org/981843003/diff/60001/pdf/out_of_process_instance.cc File pdf/out_of_process_instance.cc (right): https://codereview.chromium.org/981843003/diff/60001/pdf/out_of_process_instance.cc#newcode612 pdf/out_of_process_instance.cc:612: options->uniform_page_size = PP_Size(uniform_page_size); On 2015/03/09 00:12:31, raymes wrote: > ...
5 years, 9 months ago (2015-03-09 22:03:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981843003/140001
5 years, 9 months ago (2015-03-10 22:25:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/48723)
5 years, 9 months ago (2015-03-11 00:38:19 UTC) #11
Lei Zhang
+tsepez for ppapi/proxy/ppapi_messages.h
5 years, 9 months ago (2015-03-11 01:17:31 UTC) #13
Tom Sepez
lgtm https://codereview.chromium.org/981843003/diff/140001/components/printing/renderer/print_web_view_helper.cc File components/printing/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/981843003/diff/140001/components/printing/renderer/print_web_view_helper.cc#newcode314 components/printing/renderer/print_web_view_helper.cc:314: // Disable scaling when: nit: when either: (or ...
5 years, 9 months ago (2015-03-11 19:11:09 UTC) #14
Lei Zhang
https://codereview.chromium.org/981843003/diff/140001/components/printing/renderer/print_web_view_helper.cc File components/printing/renderer/print_web_view_helper.cc (right): https://codereview.chromium.org/981843003/diff/140001/components/printing/renderer/print_web_view_helper.cc#newcode314 components/printing/renderer/print_web_view_helper.cc:314: // Disable scaling when: On 2015/03/11 19:11:09, Tom Sepez ...
5 years, 9 months ago (2015-03-11 20:04:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981843003/180001
5 years, 9 months ago (2015-03-11 20:05:36 UTC) #18
commit-bot: I haz the power
Committed patchset #8 (id:180001)
5 years, 9 months ago (2015-03-11 22:21:05 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-11 22:21:46 UTC) #20
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/957b445184639d1c6d141a6eca7bed8c89b142de
Cr-Commit-Position: refs/heads/master@{#320167}

Powered by Google App Engine
This is Rietveld 408576698