Issue 98183009: Use a real package-root for all of our samples instead of buildDir/packages/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98183009: Use a real package-root for all of our samples instead of buildDir/packages/

Created:
6 years, 11 months ago by kustermann

Modified:
6 years, 11 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use a real package-root for all of our samples instead of buildDir/packages/ For all tests that depend on other packages (e.g. samples) we can - use packages from pub.dartlang.org - use packages from pub.dartlang.org with overrides for the packages we have in the dart repository.

Patch Set 1 #

Patch Set 2 : #

Total comments: 5

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+269 lines, -19 lines)			Patch
M	dart/pkg/pkg.status	View	1	1 chunk	+32 lines, -0 lines	2 comments	Download
M	dart/pkg/polymer/example/canonicalization/pubspec.yaml	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/tools/testing/dart/status_file_parser.dart	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	dart/tools/testing/dart/test_runner.dart	View	1	7 chunks	+112 lines, -5 lines	1 comment	Download
M	dart/tools/testing/dart/test_suite.dart	View	1	8 chunks	+121 lines, -12 lines	2 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

ricow1

6 years, 11 months ago (2014-01-06 10:39:14 UTC) #1

https://codereview.chromium.org/98183009/diff/20001/dart/pkg/pkg.status
File dart/pkg/pkg.status (right):

https://codereview.chromium.org/98183009/diff/20001/dart/pkg/pkg.status#newco...
dart/pkg/pkg.status:341: analyzer/test/generated/scanner_test: PubGetError
this is the only dartium specific one, put the others under a
$use_repository_packages section and remove from below and above

https://codereview.chromium.org/98183009/diff/20001/dart/pkg/pkg.status#newco...
dart/pkg/pkg.status:350: [ $checked || $unchecked ]
isn't this _all_ cases, just put at the top, and do we have a bug for this?

https://codereview.chromium.org/98183009/diff/20001/dart/tools/testing/dart/t...
File dart/tools/testing/dart/test_runner.dart (right):

https://codereview.chromium.org/98183009/diff/20001/dart/tools/testing/dart/t...
dart/tools/testing/dart/test_runner.dart:540: }).then((_) {
delete this line, there is nothing async in the block above

https://codereview.chromium.org/98183009/diff/20001/dart/tools/testing/dart/t...
File dart/tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/98183009/diff/20001/dart/tools/testing/dart/t...
dart/tools/testing/dart/test_suite.dart:711: }).then((_) {
remove line, nothing async above

https://codereview.chromium.org/98183009/diff/20001/dart/tools/testing/dart/t...
dart/tools/testing/dart/test_suite.dart:850:
createPubspecCheckoutDirectory(packageDir);
where is this method defined?

Expand Messages | Collapse Messages