Issue 98183003: Docserver: Fix GitHub authentication issues that have recently cropped up: use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98183003: Docserver: Fix GitHub authentication issues that have recently cropped up: use (Closed)

Created:
7 years ago by not at google - send to devlin

Modified:
7 years ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Docserver: Fix GitHub authentication issues that have recently cropped up: use base64.b64encode not base64.encode because the latter inserts a \n, and add a User-Agent header. R=yoz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238209

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
M	chrome/common/extensions/docs/server2/app.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/docs/server2/appengine_url_fetcher.py	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/docs/server2/cron.yaml	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

not at google - send to devlin

7 years ago (2013-12-02 22:25:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r238209 (presubmit successful).