Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 98183002: Remove duplicated headers from wtf/ (Closed)

Created:
7 years ago by lgombos
Modified:
7 years ago
Reviewers:
eseidel
CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove duplicated headers from wtf/ directory where the implementation file includes the same dependencies as the corresponding primary header. BUG=317231 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162998

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -33 lines) Patch
Source/wtf/ArrayBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/ArrayBuffer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
Source/wtf/ArrayBufferContents.h View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/ArrayBufferContents.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/DataLog.h View 1 chunk +3 lines, -2 lines 0 comments Download
Source/wtf/DataLog.cpp View 1 chunk +1 line, -4 lines 0 comments Download
Source/wtf/DateMath.h View 1 chunk +0 lines, -7 lines 0 comments Download
Source/wtf/DateMath.cpp View 1 chunk +1 line, -1 line 0 comments Download
Source/wtf/DecimalNumber.h View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/DecimalNumber.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
Source/wtf/GregorianDateTime.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
Source/wtf/PageAllocator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/ThreadIdentifierDataPthreads.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/WTF.h View 1 chunk +1 line, -0 lines 0 comments Download
Source/wtf/WTF.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/text/Base64.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/text/StringImpl.h View 1 chunk +0 lines, -1 line 1 comment Download
Source/wtf/text/TextCodec.cpp View 1 chunk +0 lines, -1 line 0 comments Download
Source/wtf/text/TextEncoding.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
lgombos
wtf is small enough directory that I could manually check if we should remove the ...
7 years ago (2013-12-02 05:21:37 UTC) #1
eseidel
Removing header includes from .cpp files is largely a noop. Removing header includes from other ...
7 years ago (2013-12-02 05:31:01 UTC) #2
eseidel
https://codereview.chromium.org/98183002/diff/1/Source/wtf/text/StringImpl.h File Source/wtf/text/StringImpl.h (left): https://codereview.chromium.org/98183002/diff/1/Source/wtf/text/StringImpl.h#oldcode29 Source/wtf/text/StringImpl.h:29: I think these may only apply to windows...
7 years ago (2013-12-02 05:31:23 UTC) #3
eseidel
lgtm If it builds, OK.
7 years ago (2013-12-02 05:31:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/98183002/1
7 years ago (2013-12-02 05:32:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=19129
7 years ago (2013-12-02 08:05:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/98183002/1
7 years ago (2013-12-02 15:35:38 UTC) #7
commit-bot: I haz the power
7 years ago (2013-12-02 16:34:01 UTC) #8
Message was sent while issue was closed.
Change committed as 162998

Powered by Google App Engine
This is Rietveld 408576698