base: Add/Fix namespace closing comments.

base/threading/thread_restrictions.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_THREADING_THREAD_RESTRICTIONS_H_
 #define BASE_THREADING_THREAD_RESTRICTIONS_H_
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 
@@ skipping 25 matching lines @@
 namespace content {
 class BrowserGpuChannelHostFactory;
 class BrowserGpuMemoryBufferManager;
 class BrowserShutdownProfileDumper;
 class BrowserTestBase;
 class GpuChannelHost;
 class NestedMessagePumpAndroid;
 class RenderWidgetResizeHelper;
 class ScopedAllowWaitForAndroidLayoutTests;
 class TextInputClientMac;
-}
+}  // namespace content

[rvargas (doing something else), 2015/03/06 22:53:42]

I'm fine either way, but this is an interesting example for the conversation:

The style guide would require all namespaces to be terminated with a comment
(although even the style guide have at least one example that don't follow that
rule), but the tool clearly considers some things in this file simple enough to
not require the comment...

and given that better readability is the whole point, I'd argue that a few empty
lines in this code will do more for readability than the comment closing the
namespace. Specifically this line reads better without the comment, or with the
comment but an empty line after it, than with comment and no separation from the
next line.

[danakj, 2015/03/06 22:59:18]

Ya this one is weird, I agree. It went over the "obvious where the start of the
namespace" threshold. Personally I am happy to accept something like this to
avoid having to think about it when writing/reviewing CLs though.

Ideally the tool could say "everything inside this namespace is forward
declarations" and ignore it though, IMHO.

 namespace dbus {
 class Bus;
 }
 namespace disk_cache {
 class BackendImpl;
 class InFlightIO;
 }
 namespace mojo {
 namespace common {
 class WatcherThreadManager;
@@ skipping 172 matching lines @@
 
     DISALLOW_COPY_AND_ASSIGN(ScopedAllowWait);
   };
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(ThreadRestrictions);
 };
 
 }  // namespace base
 
 #endif  // BASE_THREADING_THREAD_RESTRICTIONS_H_