Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 981753002: Turn on property tree verification for layout tests (Closed)

Created:
5 years, 9 months ago by enne (OOO)
Modified:
5 years, 9 months ago
Reviewers:
Ian Vollick, Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn on property tree verification for layout tests This add DCHECKs when running all layout tests to verify that the new property tree approach generates the same results as the old calculate draw properties approach. R=mkwst@chromium.org,vollick@chromium.org Committed: https://crrev.com/d560578bca1374425e338f1623ad1afa63aa4e2b Cr-Commit-Position: refs/heads/master@{#321705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/shell/app/shell_main_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
enne (OOO)
5 years, 9 months ago (2015-03-09 17:51:21 UTC) #1
Mike West
The bot is very unhappy. If it's just the bot, then LGTM! Land it! If ...
5 years, 9 months ago (2015-03-10 10:17:41 UTC) #3
Ian Vollick
On 2015/03/10 10:17:41, Mike West (OOO) wrote: > The bot is very unhappy. If it's ...
5 years, 9 months ago (2015-03-10 13:31:16 UTC) #4
Ian Vollick
On 2015/03/10 13:31:16, vollick wrote: > On 2015/03/10 10:17:41, Mike West (OOO) wrote: > > ...
5 years, 9 months ago (2015-03-21 15:23:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981753002/1
5 years, 9 months ago (2015-03-21 15:24:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-22 05:14:29 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-22 05:15:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d560578bca1374425e338f1623ad1afa63aa4e2b
Cr-Commit-Position: refs/heads/master@{#321705}

Powered by Google App Engine
This is Rietveld 408576698