Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: sky/engine/bindings/BUILD.gn

Issue 981733009: Fix all dartanalyzer errors in dart:sky except the Native ones. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/scripts/compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/BUILD.gn
diff --git a/sky/engine/bindings/BUILD.gn b/sky/engine/bindings/BUILD.gn
index cf42a0a4af0478ada501c06f1ca08af23f46f14f..56cd595f07df5856e2173cbdcdb42b5bf9d5925e 100644
--- a/sky/engine/bindings/BUILD.gn
+++ b/sky/engine/bindings/BUILD.gn
@@ -50,7 +50,7 @@ source_set("bindings") {
action("generate_snapshot_bin") {
deps = [
"//dart/runtime/bin:gen_snapshot($host_toolchain)",
- ":generate_sky_core_dart",
+ ":generate_dart_sky",
]
inputs = [
"//dart/runtime/tools/create_snapshot_bin.py",
@@ -81,7 +81,7 @@ action("generate_snapshot_bin") {
]
builtin_path = rebase_path("//sky/engine/bindings/builtin.dart")
- sky_core_path = rebase_path("$bindings_output_dir/sky_core.dart")
+ dart_sky_path = rebase_path("$bindings_output_dir/dart_sky.dart")
mojo_bindings_path = rebase_path("//mojo/public/dart/bindings.dart")
mojo_core_path = rebase_path("//mojo/public/dart/core.dart")
@@ -101,7 +101,7 @@ action("generate_snapshot_bin") {
rebase_path(output, root_build_dir),
"--target_os",
os,
- "--url_mapping=dart:sky,$sky_core_path",
+ "--url_mapping=dart:sky,$dart_sky_path",
"--url_mapping=mojo:bindings,$mojo_bindings_path",
"--url_mapping=mojo:core,$mojo_core_path",
"--url_mapping=dart:sky_builtin,$builtin_path",
@@ -334,7 +334,7 @@ action("generate_dart_globals") {
]
}
-action("generate_sky_core_dart") {
+action("generate_dart_sky") {
sources = core_idl_files
script = "$bindings_scripts_dir/compiler.py"
@@ -346,7 +346,7 @@ action("generate_sky_core_dart") {
outputs = [
file_list,
- "$bindings_output_dir/sky_core.dart",
+ "$bindings_output_dir/dart_sky.dart",
]
args = [
« no previous file with comments | « no previous file | sky/engine/bindings/scripts/compiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698