Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: shell/native_runner_unittest.cc

Issue 981733002: Rename {In,OutOf}ProcessDynamicServiceRunner -> ...NativeRunner. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: remove incorrect/flaky NOTREACHED() Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/launcher_main.cc ('k') | shell/out_of_process_dynamic_service_runner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: shell/native_runner_unittest.cc
diff --git a/shell/native_runner_unittest.cc b/shell/native_runner_unittest.cc
index 3ac197141ce6c665fbcbaef79bfd689835aff0ed..b9c5776927027e9d8e5e4fe67265338d838ed675 100644
--- a/shell/native_runner_unittest.cc
+++ b/shell/native_runner_unittest.cc
@@ -9,7 +9,6 @@
#include "testing/gtest/include/gtest/gtest.h"
namespace mojo {
-
namespace {
struct TestState {
@@ -55,8 +54,6 @@ class TestNativeRunnerFactory : public NativeRunnerFactory {
TestState* state_;
};
-} // namespace
-
class NativeApplicationLoaderTest : public testing::Test,
public ApplicationManager::Delegate {
public:
@@ -80,7 +77,7 @@ class NativeApplicationLoaderTest : public testing::Test,
private:
// ApplicationManager::Delegate
- void OnApplicationError(const GURL& url) override { NOTREACHED(); }
+ void OnApplicationError(const GURL& url) override {}
GURL ResolveURL(const GURL& url) override { return url; }
@@ -101,4 +98,5 @@ TEST_F(NativeApplicationLoaderTest, DoesNotExist) {
EXPECT_FALSE(state_.runner_was_destroyed);
}
+} // namespace
} // namespace mojo
« no previous file with comments | « shell/launcher_main.cc ('k') | shell/out_of_process_dynamic_service_runner.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698