GCM Checkin implementation with unit tests and protobufs

google_apis/gcm/gcm_client.h

Index: google_apis/gcm/gcm_client.h
diff --git a/google_apis/gcm/gcm_client.h b/google_apis/gcm/gcm_client.h
index 4f391eba817fa86abe32d13264f4ad53f96a7302..b49462f32b180ace6e5819a75df32beac4bcc73f 100644
--- a/google_apis/gcm/gcm_client.h
+++ b/google_apis/gcm/gcm_client.h
@@ -11,6 +11,7 @@
 
 #include "base/basictypes.h"
 #include "google_apis/gcm/base/gcm_export.h"
+#include "google_apis/gcm/protocol/checkin.pb.h"
 
 namespace base {
 class TaskRunner;
@@ -76,6 +77,17 @@ class GCM_EXPORT GCMClient {
     uint64 secret;
   };
 
+  // The check-in info of Chrome build.
+  struct GCM_EXPORT ChromeCheckInInfo {

[jianli, 2014/01/04 01:34:10]

ChromeCheckInInfo can be easily confused with CheckInInfo. This is indeed the
Chrome info passed to the check-in request. Why not just simply using
ChromeBuildProto to pass the info?

[fgorski, 2014/01/06 20:34:12]

Done.

+    ChromeCheckInInfo()
+        : platform(checkin_proto::ChromeBuildProto::PLATFORM_WIN),
+          channel(checkin_proto::ChromeBuildProto::CHANNEL_UNKNOWN) {}
+
+    checkin_proto::ChromeBuildProto_Platform platform;
+    checkin_proto::ChromeBuildProto_Channel channel;
+    std::string chrome_version;
+  };
+
   // A delegate interface that allows the GCMClient instance to interact with
   // its caller, i.e. notifying asynchronous event.
   class Delegate {