Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2980)

Unified Diff: chrome/browser/services/gcm/gcm_profile_service.h

Issue 98173009: GCM Checkin implementation with unit tests and protobufs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-store
Patch Set: Updating the copyright notice Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/gcm_profile_service.h
diff --git a/chrome/browser/services/gcm/gcm_profile_service.h b/chrome/browser/services/gcm/gcm_profile_service.h
index 258ff8290ca7e9df8b39e834bb874c2c9abbe69f..e34c1aa8533a3d2576ceab2216e784004a878453 100644
--- a/chrome/browser/services/gcm/gcm_profile_service.h
+++ b/chrome/browser/services/gcm/gcm_profile_service.h
@@ -50,7 +50,7 @@ class GCMProfileService : public BrowserContextKeyedService,
class TestingDelegate {
public:
virtual GCMEventRouter* GetEventRouter() const = 0;
- virtual void CheckInFinished(const GCMClient::CheckInInfo& checkin_info,
+ virtual void CheckInFinished(const GCMClient::CheckinInfo& checkin_info,
GCMClient::Result result) = 0;
};
@@ -140,7 +140,8 @@ class GCMProfileService : public BrowserContextKeyedService,
const GCMClient::OutgoingMessage& message);
// Callbacks posted from IO thread to UI thread.
- void CheckInFinished(GCMClient::CheckInInfo checkin_info,
+ // TODO(fgorski): Update parameters to be passed by const ref.
+ void CheckInFinished(GCMClient::CheckinInfo checkin_info,
GCMClient::Result result);
void RegisterFinished(std::string app_id,
std::string registration_id,

Powered by Google App Engine
This is Rietveld 408576698