Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/browser/services/gcm/gcm_client_mock.h

Issue 98173009: GCM Checkin implementation with unit tests and protobufs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-store
Patch Set: Updating the copyright notice Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/services/gcm/gcm_client_mock.h
diff --git a/chrome/browser/services/gcm/gcm_client_mock.h b/chrome/browser/services/gcm/gcm_client_mock.h
index aeca13a5449c4492ec7337e3d5757f14fbb3977e..add87e230f96201a59f74c0e783ba7f307557717 100644
--- a/chrome/browser/services/gcm/gcm_client_mock.h
+++ b/chrome/browser/services/gcm/gcm_client_mock.h
@@ -47,7 +47,7 @@ class GCMClientMock : public GCMClient {
void SetIsLoading(bool is_loading);
- static CheckInInfo GetCheckInInfoFromUsername(const std::string& username);
+ static CheckinInfo GetCheckinInfoFromUsername(const std::string& username);
static std::string GetRegistrationIdFromSenderIds(
const std::vector<std::string>& sender_ids);
@@ -55,7 +55,8 @@ class GCMClientMock : public GCMClient {
Delegate* GetDelegate(const std::string& username) const;
// Called on IO thread.
- void CheckInFinished(std::string username, CheckInInfo checkin_info);
+ // TODO(fgorski): Update parameters to const ref.
+ void CheckInFinished(std::string username, CheckinInfo checkin_info);
void RegisterFinished(std::string username,
std::string app_id,
std::string registrion_id);
« no previous file with comments | « no previous file | chrome/browser/services/gcm/gcm_client_mock.cc » ('j') | google_apis/gcm/engine/checkin_request.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698