google_apis/gcm/gcm.gyp - Issue 98173009: GCM Checkin implementation with unit tests and protobufs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm.gyp

Issue 98173009: GCM Checkin implementation with unit tests and protobufs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gcm-store

Patch Set: Updates based on CR comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« google_apis/gcm/engine/gcm_checkin_request.cc ('K') | « google_apis/gcm/engine/gcm_checkin_request_unittest.cc ('k') | google_apis/gcm/protocol/android_checkin.proto » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/gcm.gyp

diff --git a/google_apis/gcm/gcm.gyp b/google_apis/gcm/gcm.gyp

index 79ecd0e6906846929d4a1cce1faa1e28d7cef188..5019c5045b0f5a243ffb4b26a6bb40e8e1720632 100644

--- a/google_apis/gcm/gcm.gyp

+++ b/google_apis/gcm/gcm.gyp

@@ -52,6 +52,8 @@

'engine/connection_handler.cc',

'engine/connection_handler_impl.h',

'engine/connection_handler_impl.cc',

+ 'engine/gcm_checkin_request.cc',

+ 'engine/gcm_checkin_request.h',

'engine/heartbeat_manager.h',

'engine/heartbeat_manager.cc',

'engine/mcs_client.h',

@@ -62,6 +64,8 @@

'gcm_client.h',

'gcm_client_impl.cc',

'gcm_client_impl.h',

+ 'protocol/android_checkin.proto',

+ 'protocol/checkin.proto',

'protocol/mcs.proto',

'includes': [

@@ -120,6 +124,7 @@

'engine/fake_connection_factory.cc',

'engine/fake_connection_handler.h',

'engine/fake_connection_handler.cc',

+ 'engine/gcm_checkin_request_unittest.cc',

'engine/heartbeat_manager_unittest.cc',

'engine/mcs_client_unittest.cc',

'engine/rmq_store_unittest.cc',