GCM Checkin implementation with unit tests and protobufs

google_apis/gcm/gcm_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GOOGLE_APIS_GCM_GCM_CLIENT_H_
 #define GOOGLE_APIS_GCM_GCM_CLIENT_H_
 
 #include <map>
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "google_apis/gcm/base/gcm_export.h"
+#include "google_apis/gcm/protocol/checkin.pb.h"
 
 namespace base {
 class TaskRunner;
 }
 
 namespace gcm {
 
 // Interface that encapsulates the network communications with the Google Cloud
 // Messaging server. This interface is not supposed to be thread-safe.
 class GCM_EXPORT GCMClient {
@@ skipping 45 matching lines @@
     bool IsValid() const { return android_id != 0 && secret != 0; }
     void Reset() {
       android_id = 0;
       secret = 0;
     }
 
     uint64 android_id;
     uint64 secret;
   };
 
+  // The check-in info of Chrome build.
+  struct GCM_EXPORT ChromeCheckInInfo {

[jianli, 2014/01/04 01:34:10]

ChromeCheckInInfo can be easily confused with CheckInInfo. This is indeed the
Chrome info passed to the check-in request. Why not just simply using
ChromeBuildProto to pass the info?

[fgorski, 2014/01/06 20:34:12]

Done.

+    ChromeCheckInInfo()
+        : platform(checkin_proto::ChromeBuildProto::PLATFORM_WIN),
+          channel(checkin_proto::ChromeBuildProto::CHANNEL_UNKNOWN) {}
+
+    checkin_proto::ChromeBuildProto_Platform platform;
+    checkin_proto::ChromeBuildProto_Channel channel;
+    std::string chrome_version;
+  };
+
   // A delegate interface that allows the GCMClient instance to interact with
   // its caller, i.e. notifying asynchronous event.
   class Delegate {
    public:
     // Called when the user has been checked in successfully or an error occurs.
     // |checkin_info|: valid if the checkin completed successfully.
     // |result|: the type of the error if an error occured, success otherwise.
     virtual void OnCheckInFinished(const CheckInInfo& checkin_info,
                                    Result result) = 0;
 
@@ skipping 101 matching lines @@
   // Returns true if the loading from the persistent store is still in progress.
   virtual bool IsLoading() const = 0;
 
  protected:
   virtual ~GCMClient() {}
 };
 
 }  // namespace gcm
 
 #endif  // GOOGLE_APIS_GCM_GCM_CLIENT_H_