GCM Checkin implementation with unit tests and protobufs

google_apis/gcm/engine/checkin_request.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef GOOGLE_APIS_GCM_ENGINE_CHECKIN_REQUEST_H_
+#define GOOGLE_APIS_GCM_ENGINE_CHECKIN_REQUEST_H_
+
+#include "base/basictypes.h"
+#include "base/callback.h"
+#include "google_apis/gcm/base/gcm_export.h"
+#include "google_apis/gcm/gcm_client.h"
+#include "google_apis/gcm/protocol/android_checkin.pb.h"
+#include "net/url_request/url_fetcher_delegate.h"
+
+namespace net {
+class URLRequestContextGetter;
+}
+
+namespace gcm {
+
+class GCM_EXPORT CheckinRequest : public net::URLFetcherDelegate {

[Nicolas Zea, 2014/01/07 00:41:52]

Add comment describing the purpose of this class

[fgorski, 2014/01/07 23:46:44]

Done.

+ public:
+  // A callback function for the checkin request, accepting |android_id| and
+  // |security_token|.
+  typedef base::Callback<void(uint64, uint64)> CheckinRequestCallback;
+
+  CheckinRequest(const CheckinRequestCallback& callback,
+                 const checkin_proto::ChromeBuildProto& chrome_build_proto,
+                 int64 user_serial_number,
+                 const GCMClient::CheckinInfo& checkin_info,

[Nicolas Zea, 2014/01/07 00:41:52]

It's a bit weird that a CheckinRequest takes a CheckinInfo as an input.
Considering that CheckinInfo might eventually be expanded to include the various
settings/fields the checkin response returns, and we're really only using it to
pass the id/token, perhaps just pass those explicitly?

[fgorski, 2014/01/07 23:46:44]

Done.

+                 net::URLRequestContextGetter* request_context_getter);
+  virtual ~CheckinRequest();
+
+  void Start();
+
+  // URLFetcherDelegate implementation.
+  virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+
+ private:
+  net::URLRequestContextGetter* request_context_getter_;
+  CheckinRequestCallback callback_;
+
+  scoped_ptr<net::URLFetcher> url_fetcher_;
+  checkin_proto::ChromeBuildProto chrome_build_proto_;
+  uint64 android_id_;
+  uint64 security_token_;
+  int64 user_serial_number_;
+
+  DISALLOW_COPY_AND_ASSIGN(CheckinRequest);
+};
+
+}  // namespace gcm
+
+#endif  // GOOGLE_APIS_GCM_ENGINE_CHECKIN_REQUEST_H_