tools/push-to-trunk/push_to_trunk.py - Issue 98173003: Mock out date call in push-to-trunk script for testability.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/push-to-trunk/push_to_trunk.py

Issue 98173003: Mock out date call in push-to-trunk script for testability. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/push-to-trunk/push_to_trunk.py

diff --git a/tools/push-to-trunk/push_to_trunk.py b/tools/push-to-trunk/push_to_trunk.py

index cee871fc6e478c403ea6cc78d5ac9f8138e3e515..9c9c75f5646b108959035b207cb00aac2382ed3a 100755

--- a/tools/push-to-trunk/push_to_trunk.py

+++ b/tools/push-to-trunk/push_to_trunk.py

@@ -26,7 +26,6 @@

# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-import datetime

import optparse

import sys

import tempfile

@@ -115,7 +114,7 @@ class PrepareChangeLog(Step):

# These version numbers are used again later for the trunk commit.

self.ReadAndPersistVersion()

- date = datetime.date.today().strftime("%Y-%m-%d")

+ date = self.GetDate()

self.Persist("date", date)

output = "%s: Version %s.%s.%s\n\n" % (date,

self._state["major"],

« no previous file with comments | « tools/push-to-trunk/common_includes.py ('k') | tools/push-to-trunk/test_scripts.py » ('j') | no next file with comments »