Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 98173003: Mock out date call in push-to-trunk script for testability. (Closed)

Created:
7 years ago by Michael Achenbach
Modified:
7 years ago
Reviewers:
ulan
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Mock out date call in push-to-trunk script for testability. TEST=python -m unittest test_scripts.ScriptTest.testPrepareChangeLog R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -19 lines) Patch
M tools/push-to-trunk/common_includes.py View 3 chunks +8 lines, -1 line 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 2 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
7 years ago (2013-12-03 10:46:05 UTC) #1
ulan
lgtm
7 years ago (2013-12-03 11:32:15 UTC) #2
Michael Achenbach
7 years ago (2013-12-03 12:38:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18232 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698