Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Unified Diff: remoting/webapp/base/js/application.js

Issue 981723003: Add application pre-authorization. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/base/js/application.js
diff --git a/remoting/webapp/base/js/application.js b/remoting/webapp/base/js/application.js
index 30b1126cead8e24bafee5612f19f4b56da464e37..3bd7b431364ab09268d97bf899a1acccc972007c 100644
--- a/remoting/webapp/base/js/application.js
+++ b/remoting/webapp/base/js/application.js
@@ -90,7 +90,13 @@ remoting.Application.prototype.start = function() {
// global 'remoting' namespace.
remoting.settings = new remoting.Settings();
- this.delegate_.init(this.getSessionConnector());
+ remoting.initGlobalObjects();
+ remoting.initIdentity();
+
+ this.delegate_.init();
+ remoting.identity.getToken().then(
+ this.delegate_.start.bind(this.delegate_, this.getSessionConnector()),
+ remoting.Error.handler(this.delegate_.signInFailed.bind(this.delegate_)));
};
/**
@@ -199,13 +205,30 @@ remoting.Application.prototype.getSessionConnector = function() {
remoting.Application.Delegate = function() {};
/**
- * Initialize the application and register all event handlers. After this
- * is called, the app is running and waiting for user events.
+ * Initialize the application. This is called before an OAuth token is requested
+ * and should be used for tasks such as initializing the DOM, registering event
+ * handlers, etc.
+ */
+remoting.Application.Delegate.prototype.init = function() {};
+
+/**
+ * Start the application. Once start() is called, the delegate can assume that
+ * the user has consented to all permissions specified in the manifest.
*
* @param {remoting.SessionConnector} connector
- * @return {void} Nothing.
+ * @param {string} token An OAuth access token. The delegate should not cache
+ * this token, but can assume that it will remain valid during application
+ * start-up.
+ */
+remoting.Application.Delegate.prototype.start = function(connector, token) {};
+
+/**
+ * Report an authentication error to the user. This is called in lieu of start()
+ * if the user cannot be authenticated or if they decline the app permissions.
+ *
+ * @param {remoting.Error} error The failure reason.
*/
-remoting.Application.Delegate.prototype.init = function(connector) {};
+remoting.Application.Delegate.prototype.signInFailed = function(error) {};
/**
* @return {string} Application product name to be used in UI.
@@ -240,8 +263,8 @@ remoting.Application.Delegate.prototype.handleDisconnected = function() {};
* @param {remoting.Error} error
* @return {void} Nothing.
*/
-remoting.Application.Delegate.prototype.handleConnectionFailed = function(
- connector, error) {};
+remoting.Application.Delegate.prototype.handleConnectionFailed =
+ function(connector, error) {};
/**
* Called when the current session has reached the point where the host has
@@ -249,8 +272,8 @@ remoting.Application.Delegate.prototype.handleConnectionFailed = function(
*
* @return {void} Nothing.
*/
-remoting.Application.Delegate.prototype.handleVideoStreamingStarted = function(
- ) {};
+remoting.Application.Delegate.prototype.handleVideoStreamingStarted =
+ function() {};
/**
* Called when an extension message needs to be handled.
@@ -259,8 +282,8 @@ remoting.Application.Delegate.prototype.handleVideoStreamingStarted = function(
* @param {Object} message The parsed extension message data.
* @return {boolean} Return true if the extension message was recognized.
*/
-remoting.Application.Delegate.prototype.handleExtensionMessage = function(
- type, message) {};
+remoting.Application.Delegate.prototype.handleExtensionMessage =
+ function(type, message) {};
/**
* Called when an error needs to be displayed to the user.

Powered by Google App Engine
This is Rietveld 408576698