content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 981703002: Ensure WebContentsObserver.destroy is called

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 981703002: Ensure WebContentsObserver.destroy is called (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsObserverProxy.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index f7a82e6992d0722a52d2bfc47728b1fcb3211cd7..216be3a971dbc198a1cccc4cf099d39f861eac0b 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -331,10 +331,6 @@ import org.chromium.content_public.browser.WebContentsObserver;

public void removeObserver(WebContentsObserver observer) {

if (mObserverProxy == null) return;

mObserverProxy.removeObserver(observer);

- if (!mObserverProxy.hasObservers()) {

- mObserverProxy.destroy();

- mObserverProxy = null;

- }

}

// This is static to avoid exposing a public destroy method on the native side of this class.