Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 9817026: Changes how we detect whether the launcher should be shown when (Closed)

Created:
8 years, 9 months ago by sky
Modified:
8 years, 9 months ago
CC:
chromium-reviews, sadrul, jonathan.backer, Ian Vollick, dhollowa+watch_chromium.org, ben+watch_chromium.org, piman+watch_chromium.org
Visibility:
Public.

Description

Changes how we detect whether the launcher should be shown when auto-hidden to use an EventFilter as well as whether the status area is showing a bubble. The old code didn't work right because the status is a separate widget, meaning a mouse exit always gets dispatched. I'm also fixing a bug in LayerAnimator. Getting the target value was only looking at the running animation state, not the queued animations. This was causing confusion because the workspace animations queue up a couple of animations. BUG=119296 TEST=see bug, covered by tests too. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128162

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -70 lines) Patch
M ash/launcher/launcher.cc View 7 chunks +0 lines, -37 lines 0 comments Download
M ash/system/tray/system_tray.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/system/tray/system_tray.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M ash/wm/shelf_layout_manager.h View 6 chunks +22 lines, -7 lines 0 comments Download
M ash/wm/shelf_layout_manager.cc View 8 chunks +118 lines, -9 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 5 chunks +44 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_manager.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M ui/gfx/compositor/layer_animator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/gfx/compositor/layer_animator_unittest.cc View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sky
8 years, 9 months ago (2012-03-21 23:58:52 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 9 months ago (2012-03-22 00:55:10 UTC) #2
Ben Goodger (Google)
8 years, 9 months ago (2012-03-22 00:55:30 UTC) #3
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698