Fix bug that would create unnecessary ConnectJobs in some cases.

Fix bug that would create unnecessary ConnectJobs in some cases.

When a ConnectJob failed and there was another socket request pending
for the same group, a new ConnectJob would always be created, even if
the pending request already had its own ConnectJob.

BUG=463960
Committed: https://crrev.com/6be122fb693fe8f2a5b150a12bddd5c85160b7a6
Cr-Commit-Position: refs/heads/master@{#319750}

[mmenke, 2015-03-04 22:38:17]

Patchset #2 (id:20001) has been deleted

[mmenke, 2015-03-04 22:48:42]

mmenke@chromium.org changed reviewers:
+ davidben@chromium.org

[mmenke, 2015-03-04 22:48:43]

No rush on this.  Sending this to you because no one really owns the socket
pools, and you're the last net/ person to land changes here (Which I reviewed).

Discovered this when looking into a crash.

https://codereview.chromium.org/981643002/diff/40001/net/socket/client_socket...
File net/socket/client_socket_pool_base.cc (right):

https://codereview.chromium.org/981643002/diff/40001/net/socket/client_socket...
net/socket/client_socket_pool_base.cc:922: OnAvailableSocketSlot(group_name,
group);
The issue is this was resulting in always making a new connection, as long as
there was a pending request, even if there were as many or more ConnectJobs
already.

Could actually get rid of this call, and just delete the group if it were empty.
 That means we'd look for the highest priority group, which would probably be
better...  But that seems a bit far afield from just fixing this bug.

[davidben, 2015-03-09 18:34:55]

lgtm

[mmenke, 2015-03-09 18:42:22]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2015-03-09 18:42:28]

On 2015/03/09 18:34:55, David Benjamin wrote:
> lgtm

Thanks!

[commit-bot: I haz the power, 2015-03-09 18:43:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/981643002/40001

[commit-bot: I haz the power, 2015-03-09 22:22:54]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-09 22:23:24]

Patchset 2 (id:??) landed as
https://crrev.com/6be122fb693fe8f2a5b150a12bddd5c85160b7a6
Cr-Commit-Position: refs/heads/master@{#319750}