Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc

Issue 981633002: Created new URLRequestContext for secure proxy check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed the tests Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
index cdc4f8af22f5df791148f0754e4c9db497d53319..a1974b5d691bd67c0258872047357429baa6bf8c 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc
@@ -194,6 +194,21 @@ TEST(DataReductionProxySettingsStandaloneTest, TestEndToEndSecureProxyCheck) {
.SkipSettingsInitialization()
.Build();
+ // Enabling QUIC should have no effect since secure proxy should not
bengr 2015/03/16 23:21:06 I don't understand. Why are you enabling QUIC if i
tbansal1 2015/03/19 22:43:57 Added more details to the comment.
+ // use QUIC.
+ net::HttpNetworkSession::Params* params =
+ new net::HttpNetworkSession::Params();
+ params->use_alternate_protocols = true;
+ params->enable_quic = true;
+ params->origin_to_force_quic_on =
+ net::HostPortPair::FromString(
+ TestDataReductionProxyParams::DefaultSecureProxyCheckURL());
+
+ //context.set_http_network_session_params(
bengr 2015/03/16 23:21:06 Remove dead code.
tbansal1 2015/03/19 22:43:57 Done.
+ // *(const_cast<const net::HttpNetworkSession::Params*>(params)));
+
+ context.set_http_network_session_params(*params);
+
context.set_net_log(drp_test_context->net_log());
net::MockClientSocketFactory mock_socket_factory;
context.set_client_socket_factory(&mock_socket_factory);

Powered by Google App Engine
This is Rietveld 408576698