components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc - Issue 981633002: Created new URLRequestContext for secure proxy check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

Issue 981633002: Created new URLRequestContext for secure proxy check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved secure proxy check to DRPConfig Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc ('K') | « components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h » ('j') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

index bd5a10db625155aa76b32d840a33a7e0c8d956dd..d6668752802214e32eed11d99cfca06e47c51d88 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc

@@ -126,13 +126,11 @@ class DataReductionProxyConfigTest : public testing::Test {

!config()->restricted_by_carrier_,

request_succeeded && (response == "OK")),

request_succeeded, 1);

- MockDataReductionProxyService* service =

- test_context_->mock_data_reduction_proxy_service();

TestResponder responder;

responder.response = response;

responder.status =

net::URLRequestStatus(net::URLRequestStatus::SUCCESS, net::OK);

- EXPECT_CALL(*service, SecureProxyCheck(_, _))

+ EXPECT_CALL(*(config()), SecureProxyCheck(_, _))

.Times(1)

.WillRepeatedly(testing::WithArgs<1>(

testing::Invoke(&responder, &TestResponder::ExecuteCallback)));