Created new URLRequestContext for secure proxy check

net/http/http_stream_factory_impl_job.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_stream_factory_impl_job.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 689 matching lines @@
   if (blocking_job_)
     next_state_ = STATE_WAIT_FOR_JOB;
   else
     next_state_ = STATE_INIT_CONNECTION;
   return OK;
 }
 
 bool HttpStreamFactoryImpl::Job::ShouldForceSpdySSL() const {
   bool rv = session_->params().force_spdy_always &&
       session_->params().force_spdy_over_ssl;
-  return rv && !session_->HasSpdyExclusion(origin_);
+  return rv && !session_->HasSpdyExclusion(origin_) &&
+         (request_info_.load_flags & LOAD_UNENCRYPTED_HTTP11) == 0;
 }
 
 bool HttpStreamFactoryImpl::Job::ShouldForceSpdyWithoutSSL() const {
   bool rv = session_->params().force_spdy_always &&
       !session_->params().force_spdy_over_ssl;
-  return rv && !session_->HasSpdyExclusion(origin_);
+  return rv && !session_->HasSpdyExclusion(origin_) &&
+         (request_info_.load_flags & LOAD_UNENCRYPTED_HTTP11) == 0;
 }
 
 bool HttpStreamFactoryImpl::Job::ShouldForceQuic() const {
   return session_->params().enable_quic &&
-    session_->params().origin_to_force_quic_on.Equals(origin_) &&
-    proxy_info_.is_direct();
+         session_->params().origin_to_force_quic_on.Equals(origin_) &&
+         proxy_info_.is_direct() &&
+         (request_info_.load_flags & LOAD_UNENCRYPTED_HTTP11) == 0;
 }
 
 int HttpStreamFactoryImpl::Job::DoWaitForJob() {
   DCHECK(blocking_job_);
   next_state_ = STATE_WAIT_FOR_JOB_COMPLETE;
   return ERR_IO_PENDING;
 }
 
 int HttpStreamFactoryImpl::Job::DoWaitForJobComplete(int result) {
   DCHECK(!blocking_job_);
   DCHECK_EQ(OK, result);
   next_state_ = STATE_INIT_CONNECTION;
   return OK;
 }
 
 int HttpStreamFactoryImpl::Job::DoInitConnection() {
   // TODO(pkasting): Remove ScopedTracker below once crbug.com/462812 is fixed.
   tracked_objects::ScopedTracker tracking_profile(
       FROM_HERE_WITH_EXPLICIT_FUNCTION(
           "462812 HttpStreamFactoryImpl::Job::DoInitConnection"));
   DCHECK(!blocking_job_);
   DCHECK(!connection_->is_initialized());
   DCHECK(proxy_info_.proxy_server().is_valid());
   next_state_ = STATE_INIT_CONNECTION_COMPLETE;
 
-  using_ssl_ = request_info_.url.SchemeIs("https") ||
-      request_info_.url.SchemeIs("wss") || ShouldForceSpdySSL();
+  using_ssl_ = (request_info_.load_flags & LOAD_UNENCRYPTED_HTTP11) == 0 &&

[sclittle, 2015/03/04 21:35:23]

What happens if the load flag is set for a https URL?

[tbansal1, 2015/03/06 19:57:40]

Done.

+               (request_info_.url.SchemeIs("https") ||
+                request_info_.url.SchemeIs("wss") || ShouldForceSpdySSL());

[Ryan Hamilton, 2015/03/05 01:43:57]

This definitely seems wrong. If HTTP11 is required for a secure origins (https
or wss) that should simply be an error.

[tbansal1, 2015/03/06 19:57:40]

Done.

   using_spdy_ = false;
 
+  base::WeakPtr<HttpServerProperties> http_server_properties =
+      session_->http_server_properties();
+  if (http_server_properties)
+    if ((request_info_.load_flags & LOAD_UNENCRYPTED_HTTP11) != 0)
+      http_server_properties->SetHTTP11Required(origin_);

[sclittle, 2015/03/04 21:35:23]

Won't this also force all future requests to this origin in the session to only
use HTTP/1.1?

[tbansal1, 2015/03/06 19:57:40]

Done.

+
   if (ShouldForceQuic())
     using_quic_ = true;
 
   DCHECK(!using_quic_ || session_->params().enable_quic);
 
   if (proxy_info_.is_quic()) {
     using_quic_ = true;
     DCHECK(session_->params().enable_quic_for_proxies);
   }
 
@@ skipping 22 matching lines @@
     }
     return rv;
   }
 
   // Check first if we have a spdy session for this group.  If so, then go
   // straight to using that.
   SpdySessionKey spdy_session_key = GetSpdySessionKey();
   base::WeakPtr<SpdySession> spdy_session =
       session_->spdy_session_pool()->FindAvailableSession(
           spdy_session_key, net_log_);
   if (spdy_session && CanUseExistingSpdySession()) {

[sclittle, 2015/03/04 21:35:23]

What if there's an existing SPDY session? Could it still be possible for the
LOAD_UNENCRYPTED_HTTP11 request to use the existing SPDY session?

[tbansal1, 2015/03/06 19:57:40]

Done.

     // If we're preconnecting, but we already have a SpdySession, we don't
     // actually need to preconnect any sockets, so we're done.
     if (IsPreconnecting())
       return OK;
     using_spdy_ = true;
     next_state_ = STATE_CREATE_STREAM;
     existing_spdy_session_ = spdy_session;
     return OK;
   } else if (request_ && !request_->HasSpdySessionKey() &&
              (using_ssl_ || ShouldForceSpdyWithoutSSL())) {
@@ skipping 20 matching lines @@
                   true /* is a proxy server */);
     // Disable revocation checking for HTTPS proxies since the revocation
     // requests are probably going to need to go through the proxy too.
     proxy_ssl_config_.rev_checking_enabled = false;
   }
   if (using_ssl_) {
     InitSSLConfig(origin_, &server_ssl_config_,
                   false /* not a proxy server */);
   }
 
-  base::WeakPtr<HttpServerProperties> http_server_properties =
-      session_->http_server_properties();
   if (http_server_properties) {
     http_server_properties->MaybeForceHTTP11(origin_, &server_ssl_config_);
     if (proxy_info_.is_http() || proxy_info_.is_https()) {
       http_server_properties->MaybeForceHTTP11(
           proxy_info_.proxy_server().host_port_pair(), &proxy_ssl_config_);
     }
   }
 
   if (IsPreconnecting()) {
     DCHECK(!stream_factory_->for_websockets_);
@@ skipping 655 matching lines @@
 
   if (job_status_ == STATUS_SUCCEEDED && other_job_status_ == STATUS_BROKEN) {
     HistogramBrokenAlternateProtocolLocation(
         BROKEN_ALTERNATE_PROTOCOL_LOCATION_HTTP_STREAM_FACTORY_IMPL_JOB_MAIN);
     session_->http_server_properties()->SetBrokenAlternateProtocol(
         HostPortPair::FromURL(request_info_.url));
   }
 }
 
 }  // namespace net