Issue 98163003: Add a bit to HObjectAccess to encode immutable fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98163003: Add a bit to HObjectAccess to encode immutable fields. (Closed)

Created:
7 years ago by titzer

Modified:
6 years, 11 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add a bit to HObjectAccess to encode immutable fields. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18471

Patch Set 2 : Fix type of immutable bitfield. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	src/hydrogen-instructions.h	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm with nit https://codereview.chromium.org/98163003/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/98163003/diff/1/src/hydrogen-instructions.h#newcode6166 src/hydrogen-instructions.h:6166: class ImmutableField : public BitField<int, 7, ...

7 years ago (2013-12-06 09:18:54 UTC) #2

titzer

On 2013/12/06 09:18:54, Igor Sheludko wrote: > lgtm with nit > > https://codereview.chromium.org/98163003/diff/1/src/hydrogen-instructions.h > File ...

7 years ago (2013-12-06 09:32:27 UTC) #3

titzer

6 years, 11 months ago (2014-01-07 14:43:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r18471 (presubmit successful).

Expand Messages | Collapse Messages

Issue 98163003: Add a bit to HObjectAccess to encode immutable fields. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix type of immutable bitfield. #

Messages