Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Unified Diff: chrome/renderer/plugins/chrome_plugin_placeholder.h

Issue 981623003: Plugin Power Saver: Implement srcset syntax for posters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/plugins/chrome_plugin_placeholder.h
diff --git a/chrome/renderer/plugins/chrome_plugin_placeholder.h b/chrome/renderer/plugins/chrome_plugin_placeholder.h
index e9adb07f465c14edc3c173fbd2b05e89d974d347..cc6fda8f14d16332d23553621709121aa4e41188 100644
--- a/chrome/renderer/plugins/chrome_plugin_placeholder.h
+++ b/chrome/renderer/plugins/chrome_plugin_placeholder.h
@@ -17,6 +17,8 @@ class ChromePluginPlaceholder : public plugins::LoadablePluginPlaceholder,
public:
static const char kPluginPlaceholderDataURL[];
+ // If |poster_attribute| can contain relative paths, |base_url| must be
Tom Sepez 2015/03/05 20:28:42 nit: s/can contain/contains/
tommycli 2015/03/06 00:17:31 Done.
+ // non-empty. This is so the placeholder can resolve the relative paths.
static ChromePluginPlaceholder* CreateBlockedPlugin(
content::RenderFrame* render_frame,
blink::WebLocalFrame* frame,
@@ -26,7 +28,8 @@ class ChromePluginPlaceholder : public plugins::LoadablePluginPlaceholder,
const base::string16& name,
int resource_id,
const base::string16& message,
- const GURL& poster_url);
+ const std::string& poster_attribute,
+ const GURL& base_url);
// Creates a new WebViewPlugin with a MissingPlugin as a delegate.
static ChromePluginPlaceholder* CreateMissingPlugin(

Powered by Google App Engine
This is Rietveld 408576698