components/plugins/renderer/plugin_placeholder.cc - Issue 981623003: Plugin Power Saver: Implement srcset syntax for posters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/plugins/renderer/plugin_placeholder.cc

Issue 981623003: Plugin Power Saver: Implement srcset syntax for posters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/plugin_poster.html ('k') | components/plugins/renderer/webview_plugin.cc » ('j') | components/plugins/renderer/webview_plugin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/plugins/renderer/plugin_placeholder.cc

diff --git a/components/plugins/renderer/plugin_placeholder.cc b/components/plugins/renderer/plugin_placeholder.cc

index fbdbc5069ab597626e4239d5b8ddb1a4eff1a2b6..46862656967e355bdc47c08e4a8408da04776544 100644

--- a/components/plugins/renderer/plugin_placeholder.cc

+++ b/components/plugins/renderer/plugin_placeholder.cc

@@ -22,6 +22,8 @@ PluginPlaceholder::PluginPlaceholder(content::RenderFrame* render_frame,

render_frame->GetWebkitPreferences(),

html_data,

placeholderDataUrl)) {

+ DCHECK(placeholderDataUrl.is_valid())

+ << "Blink requires the placeholder to have a valid URL.";

}

PluginPlaceholder::~PluginPlaceholder() {}