Chromium Code Reviews Chromium Code Reviews
Issue 981623003:
Plugin Power Saver: Implement srcset syntax for posters. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: chrome/renderer/resources/plugin_poster.html |
| diff --git a/chrome/renderer/resources/plugin_poster.html b/chrome/renderer/resources/plugin_poster.html |
| index 9dc99c4189eb5d5a1787e6bad31a193c947c3f22..bf612616ddbd913288b173f5fdfb50f6b61960ed 100644 |
| --- a/chrome/renderer/resources/plugin_poster.html |
| +++ b/chrome/renderer/resources/plugin_poster.html |
| @@ -19,18 +19,19 @@ document.onkeydown = function(e) { |
| <link rel="stylesheet" href="plugin_placeholders.css"></link> |
| <style> |
| #outer { |
| + position: relative; |
| border: none; |
| cursor: pointer; |
| - background-position: center; |
| - background-repeat: no-repeat; |
| - background-size: contain; |
| } |
| #shielding { |
| background-color: rgba(0, 0, 0, 0.5); |
| - height: 100%; |
| position: absolute; |
| + top: 0px; |
| + left: 0px; |
| + height: 100%; |
| width: 100%; |
| + z-index: 2; |
| } |
| #plugin_icon { |
| @@ -41,15 +42,22 @@ document.onkeydown = function(e) { |
| opacity: 0.95; |
| } |
| +#poster { |
| + height: 100%; |
| + width: 100%; |
| + z-index: 1; |
| +} |
| + |
| #inner { |
| margin-top: -25px; |
| } |
| </style> |
| +<base i18n-values="href:baseurl"> |
| </head> |
| <body onload="notifyDidFinishLoading();"> |
| - <div i18n-values="title:name;.style.background-image:background" id="outer" |
| - onclick="plugin.load()"> |
| + <div i18n-values="title:name" id="outer" onclick="plugin.load()"> |
| + <img id="poster" i18n-values="srcset:poster"> |
|
jbroman
2015/03/06 20:25:49
I see you have security signoff, so you've probabl
tommycli
2015/03/06 21:30:55
Within the placeholder, the origin is a data URL,
jbroman
2015/03/07 03:56:02
Agreed, though there are cases where sites may con
|
| <div id="shielding"> |
| <div id="inner"> |
| <div><img id="plugin_icon" src="plugin_power_saver_play.png" /></div> |
