Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 981603002: [Extensions Toolbar] Component extensions default to the front of the toolbar (Closed)

Created:
5 years, 9 months ago by Devlin
Modified:
5 years, 9 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions Toolbar] Component extensions default to the front of the toolbar New component extensions should default to the front of the visible icons. The user can still reposition them, but for the first startup, they will now appear at the beginning. BUG=463938 Committed: https://crrev.com/4e4200b5a7c35ff8478766426572ea3c6b3fa57f Cr-Commit-Position: refs/heads/master@{#319747}

Patch Set 1 #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M chrome/browser/extensions/extension_toolbar_model.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_toolbar_model_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (12 generated)
Devlin
Finnur, mind taking a look?
5 years, 9 months ago (2015-03-05 19:23:28 UTC) #2
Finnur
LGTM
5 years, 9 months ago (2015-03-06 14:34:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981603002/1
5 years, 9 months ago (2015-03-07 06:52:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 08:52:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981603002/1
5 years, 9 months ago (2015-03-07 16:40:55 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 18:42:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981603002/1
5 years, 9 months ago (2015-03-09 05:03:59 UTC) #13
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 05:52:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981603002/20001
5 years, 9 months ago (2015-03-09 18:02:10 UTC) #19
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 19:11:07 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981603002/20001
5 years, 9 months ago (2015-03-09 22:12:13 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 22:13:50 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 22:15:51 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e4200b5a7c35ff8478766426572ea3c6b3fa57f
Cr-Commit-Position: refs/heads/master@{#319747}

Powered by Google App Engine
This is Rietveld 408576698