Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 981533003: [turbofan] Simplify and fix JS typed lowering type init. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Simplify and fix JS typed lowering type init. Removing and fixing some embarrassing stuff in js-typed-lowering. BUG= R=bmeurer@chromium.org Committed: https://crrev.com/4686448a1738b7bf9fb5a4882706a4ba6829108d Cr-Commit-Position: refs/heads/master@{#26991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +5 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 9 months ago (2015-03-04 14:42:53 UTC) #1
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-04 14:43:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981533003/1
5 years, 9 months ago (2015-03-04 14:44:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 14:55:27 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 14:55:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4686448a1738b7bf9fb5a4882706a4ba6829108d
Cr-Commit-Position: refs/heads/master@{#26991}

Powered by Google App Engine
This is Rietveld 408576698