Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 981483002: Remove Unused setTopControlsContentOffset function (Closed)

Created:
5 years, 9 months ago by sujith
Modified:
5 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, qsr+mojo_chromium.org, MuVen, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Unused setTopControlsContentOffset function Removed the unused function setTopControlsContentOffset. since it became unused after introducing the setTopControlsShownRatio. BUG= Committed: https://crrev.com/aeb8fb61aaf91e30bc6cd033d50138e581010698 Cr-Commit-Position: refs/heads/master@{#319230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
sujith
PTAL
5 years, 9 months ago (2015-03-04 10:08:51 UTC) #2
aelias_OOO_until_Jul13
lgtm, thanks.
5 years, 9 months ago (2015-03-04 17:21:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981483002/1
5 years, 9 months ago (2015-03-04 21:11:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47323)
5 years, 9 months ago (2015-03-04 21:32:09 UTC) #7
sujith
PTAL
5 years, 9 months ago (2015-03-04 21:45:06 UTC) #9
sujith
PTAL Adding sievers@ for content/ OWNERS
5 years, 9 months ago (2015-03-04 22:39:34 UTC) #11
jamesr
mojo lgtm
5 years, 9 months ago (2015-03-04 22:40:47 UTC) #12
no sievers
lgtm
5 years, 9 months ago (2015-03-04 22:55:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981483002/1
5 years, 9 months ago (2015-03-05 06:12:10 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-05 07:03:45 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 07:04:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aeb8fb61aaf91e30bc6cd033d50138e581010698
Cr-Commit-Position: refs/heads/master@{#319230}

Powered by Google App Engine
This is Rietveld 408576698