Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 981473003: Revert of Chromecast: Play audio streams not supported by CMA via default renderer (Closed)

Created:
5 years, 9 months ago by Finnur
Modified:
5 years, 9 months ago
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, feature-media-reviews_chromium.org, erickung1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Chromecast: Play audio streams not supported by CMA via default renderer (patchset #5 id:70001 of https://codereview.chromium.org/973633002/) Reason for revert: Audio tests started failing consistently in the next build after this was checked in. See: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/3762 Not sure if this CL is the culprit, but seems the most likely one, so attempting a revert to see if it fixes the problem. Error: [ RUN ] AudioRecorderTest.BasicRecordAndStop ../../components/audio_modem/audio_recorder_unittest.cc:203: Failure Value of: IsRecording() Actual: false Expected: true ../../components/audio_modem/audio_recorder_unittest.cc:208: Failure Value of: IsRecording() Actual: false Expected: true ../../components/audio_modem/audio_recorder_unittest.cc:213: Failure Value of: IsRecording() Actual: false Expected: true [ FAILED ] AudioRecorderTest.BasicRecordAndStop (1292 ms) Original issue's description: > Chromecast: Play audio streams not supported by CMA via default renderer > > For Chromecast we want to choose which media renderer to use based on > the types of input content streams. We will use CMA media renderer for > media types that are supported by our hardware (H264, AAC, etc) and > will use the default media renderer for audio streams other than AAC > or Vorbis. This will allow us support software decoding of FLAC and > Opus via the default Chrome audio path. > > BUG=457959 > > Committed: https://crrev.com/2e583073b996e66d62f709dd2ffde9e1ef58b276 > Cr-Commit-Position: refs/heads/master@{#318941} TBR=gunsch@chromium.org,lcwu@chromium.org,dalecurtis@chromium.org,servolk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457959 Committed: https://crrev.com/ee687fd9c6c2bc41642cd8b65de87fe548a3cf75 Cr-Commit-Position: refs/heads/master@{#319033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -292 lines) Patch
M chromecast/chromecast.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
D chromecast/media/base/switching_media_renderer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chromecast/media/base/switching_media_renderer.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M chromecast/media/media.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chromecast/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/renderer/cast_content_renderer_client.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chromecast/renderer/media/chromecast_media_renderer_factory.h View 1 chunk +0 lines, -43 lines 0 comments Download
D chromecast/renderer/media/chromecast_media_renderer_factory.cc View 1 chunk +0 lines, -73 lines 0 comments Download
A chromecast/renderer/media/cma_media_renderer_factory.h View 1 chunk +32 lines, -0 lines 0 comments Download
A chromecast/renderer/media/cma_media_renderer_factory.cc View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Finnur
Created Revert of Chromecast: Play audio streams not supported by CMA via default renderer
5 years, 9 months ago (2015-03-04 08:42:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981473003/1
5 years, 9 months ago (2015-03-04 08:42:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 08:43:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee687fd9c6c2bc41642cd8b65de87fe548a3cf75 Cr-Commit-Position: refs/heads/master@{#319033}
5 years, 9 months ago (2015-03-04 08:43:48 UTC) #4
Finnur
5 years, 9 months ago (2015-03-04 09:57:46 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/967933003/ by finnur@chromium.org.

The reason for reverting is: Hmmm... My revert did not fix the test, so I'm
undoing it. :/.

Powered by Google App Engine
This is Rietveld 408576698