Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 981473002: Disable experimental natives when creating a start-up snapshot. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-dev, Dmitry Lomov (no reviews)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable experimental natives when creating a start-up snapshot. Re-installing experimental natives after deserialization causes failures if said experimental native is already included in the snapshot. However, there is no way to tell whether a certain harmony feature has been included. Experimental natives may also be turned on/off on-demand, which a snapshot that includes them would not support for all cases. The simple solution for the meantime is to never include experimental natives in the snapshot and initialize them after deserialization on-demand. R=vogelheim@chromium.org Committed: https://crrev.com/efe828e6999fe84a14a8a4bd0c5ddc9bac9d4dc0 Cr-Commit-Position: refs/heads/master@{#26982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M src/bootstrapper.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M src/mksnapshot.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Yang
This is actually long overdue.
5 years, 9 months ago (2015-03-04 07:45:15 UTC) #1
vogelheim
lgtm
5 years, 9 months ago (2015-03-04 12:40:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981473002/1
5 years, 9 months ago (2015-03-04 12:44:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 13:01:28 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:01:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efe828e6999fe84a14a8a4bd0c5ddc9bac9d4dc0
Cr-Commit-Position: refs/heads/master@{#26982}

Powered by Google App Engine
This is Rietveld 408576698