Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issue 981463005: Revert of Default-enable external startup data for Linux for stand-alone builds. (Closed)

Created:
5 years, 9 months ago by vogelheim
Modified:
5 years, 9 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Default-enable external startup data for Linux for stand-alone builds. (patchset #1 id:1 of https://codereview.chromium.org/956373002/) Reason for revert: The CL caused two issues: - a weird build issue on V8 mips builder - d8 cannot be invoked via PATH, since then it doesn't find its external snapshot. The 2nd issue might even be WAI, but this needs more consideration. Original issue's description: > Default-enable external startup data for Linux for stand-alone builds. > > Notes: > - Other platforms to follow later. > - This follows Chromium practice, that mostly uses this feature these days. > - The statically linked-in startup data will stay. So whoever prefers > the old way just needs to set the flag differently. > > Reland crrev.com/959693002, once crrev.com/960883003 is in. > > R=machenbach@chromium.org > BUG= > > Committed: https://crrev.com/a0bdb103b676b4c7fa6b9f2e7149e716549c05d1 > Cr-Commit-Position: refs/heads/master@{#26980} TBR=machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/45ce8047822c76775b66be769856fd407d614023 Cr-Commit-Position: refs/heads/master@{#26986}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vogelheim
Created Revert of Default-enable external startup data for Linux for stand-alone builds.
5 years, 9 months ago (2015-03-04 13:52:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981463005/1
5 years, 9 months ago (2015-03-04 13:53:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 13:53:15 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 13:53:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45ce8047822c76775b66be769856fd407d614023
Cr-Commit-Position: refs/heads/master@{#26986}

Powered by Google App Engine
This is Rietveld 408576698