Issue 98143005: Adds PRESUBMIT.py check to look for unprefixed string16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 98143005: Adds PRESUBMIT.py check to look for unprefixed string16. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Adds PRESUBMIT.py check to look for unprefixed string16. R=maruel@chromium.org BUG=329295 TEST=PRESUBMIT_test.py NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241485

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -0 lines)			Patch
	M	PRESUBMIT.py	View		2 chunks	+30 lines, -0 lines	0 comments	Download
	M	PRESUBMIT_test.py	View		1 chunk	+40 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Dan Beam

depends on: https://codereview.chromium.org/114883004/ https://codereview.chromium.org/104003006/ https://codereview.chromium.org/108813011/

7 years ago (2013-12-17 04:59:15 UTC) #1

M-A Ruel

I assume this check will be removed once you are done with the migration? if ...

7 years ago (2013-12-17 12:19:17 UTC) #2

Dan Beam

On 2013/12/17 12:19:17, M-A Ruel wrote: > I assume this check will be removed once ...

7 years ago (2013-12-17 14:53:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/98143005/60001

7 years ago (2013-12-18 04:34:25 UTC) #4

Message was sent while issue was closed.

Change committed as 241485