Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 981423002: Remove mojo::DemuxerStreamObserver. (Closed)

Created:
5 years, 9 months ago by xhwang
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, jamesr, mikhal1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo::DemuxerStreamObserver. The observer is running on another pipe which could cause race conditions and make the implementation unnecessarily complex. This CL drops the observer and merges the config update into the main mojo::DemuxerStream interface. BUG=460154 TEST=No DCHECK fires and playback works. mojo:media_test passes. Committed: https://crrev.com/e19d54eeef0840602b27040c3ad64030da9f108c Cr-Commit-Position: refs/heads/master@{#319704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -149 lines) Patch
M media/mojo/interfaces/demuxer_stream.mojom View 1 chunk +23 lines, -26 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.h View 3 chunks +16 lines, -15 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_adapter.cc View 4 chunks +36 lines, -42 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.h View 1 chunk +4 lines, -16 lines 0 comments Download
M media/mojo/services/mojo_demuxer_stream_impl.cc View 2 chunks +60 lines, -50 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
dalecurtis: PTAL mikhal/jamesr: FYI
5 years, 9 months ago (2015-03-07 01:27:10 UTC) #2
DaleCurtis
lgtm
5 years, 9 months ago (2015-03-09 18:19:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981423002/1
5 years, 9 months ago (2015-03-09 18:35:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 19:17:53 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:18:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e19d54eeef0840602b27040c3ad64030da9f108c
Cr-Commit-Position: refs/heads/master@{#319704}

Powered by Google App Engine
This is Rietveld 408576698