Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: util/util.gyp

Issue 981393003: win: Support reading process info cross-bitness (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@64-port-test-2
Patch Set: Review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/win/process_info.h » ('j') | util/win/process_info.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/util.gyp
diff --git a/util/util.gyp b/util/util.gyp
index ba72b15c4454d30f67b335ff5db433e63b3c8e5e..28d695d7520ea5cf4a650403a974264e18e46ea5 100644
--- a/util/util.gyp
+++ b/util/util.gyp
@@ -131,6 +131,7 @@
'synchronization/semaphore.h',
'win/process_info.cc',
'win/process_info.h',
+ 'win/process_structs.h',
'win/scoped_handle.cc',
'win/scoped_handle.h',
'win/time.cc',
@@ -342,7 +343,7 @@
['OS=="win"', {
'targets': [
{
- 'target_name': 'util_test_process_info_test_child',
+ 'target_name': 'util_test_process_info_test_child_x64',
Mark Mentovai 2015/03/09 22:44:44 Do you want to add a TargetMachine: 17 definition
scottmg 2015/03/09 23:23:57 Good point, done. Needed an msvs_configuration_pla
'type': 'executable',
'sources': [
'win/process_info_test_child.cc',
@@ -359,6 +360,27 @@
},
},
},
+ {
+ # Same as above, but explicitly x86 to test 64->32 access.
+ 'target_name': 'util_test_process_info_test_child_x86',
+ 'type': 'executable',
+ 'sources': [
+ 'win/process_info_test_child.cc',
+ ],
+ 'msvs_configuration_platform': 'x86',
+ # Set an unusually high load address to make sure that the main
+ # executable still appears as the first element in
+ # ProcessInfo::Modules().
+ 'msvs_settings': {
+ 'VCLinkerTool': {
+ 'AdditionalOptions': [
+ '/BASE:0x78000000',
+ '/FIXED',
+ ],
+ 'TargetMachine': '1', # x86.
+ },
+ },
+ },
]
}],
],
« no previous file with comments | « no previous file | util/win/process_info.h » ('j') | util/win/process_info.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698