Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 981343003: Fix flake in PersonalDataManagerTest.UpdateServerCreditCardUsageStats (Closed)

Created:
5 years, 9 months ago by Evan Stade
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, nyquist, brettw, jam
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flake in PersonalDataManagerTest.UpdateServerCreditCardUsageStats BUG=464873 Committed: https://crrev.com/7748e1c675b2e90b3e207519952852c509710c5d Cr-Commit-Position: refs/heads/master@{#319964}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : xdisplaycheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (18 generated)
Evan Stade
5 years, 9 months ago (2015-03-06 23:30:00 UTC) #2
brettw
lgtm
5 years, 9 months ago (2015-03-07 00:26:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/1
5 years, 9 months ago (2015-03-07 00:29:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) mac_chromium_rel_ng on ...
5 years, 9 months ago (2015-03-07 01:30:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/1
5 years, 9 months ago (2015-03-08 01:21:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/4481)
5 years, 9 months ago (2015-03-08 02:32:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/1
5 years, 9 months ago (2015-03-08 03:22:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/4496)
5 years, 9 months ago (2015-03-08 04:39:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/1
5 years, 9 months ago (2015-03-09 06:52:38 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/4595)
5 years, 9 months ago (2015-03-09 08:03:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/1
5 years, 9 months ago (2015-03-09 17:21:07 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/4763)
5 years, 9 months ago (2015-03-09 19:45:02 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/20001
5 years, 9 months ago (2015-03-09 22:35:36 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/4953)
5 years, 9 months ago (2015-03-10 00:38:00 UTC) #28
Evan Stade
+nyquist/jam for components_unittests.gyp The trybots keep getting this failure: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/5003 the other option to "fix" ...
5 years, 9 months ago (2015-03-10 20:05:24 UTC) #30
jam
On 2015/03/10 20:05:24, Evan Stade wrote: > +nyquist/jam for components_unittests.gyp lgtm
5 years, 9 months ago (2015-03-10 20:22:12 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/981343003/40001
5 years, 9 months ago (2015-03-10 20:29:05 UTC) #34
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-10 20:48:39 UTC) #35
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7748e1c675b2e90b3e207519952852c509710c5d Cr-Commit-Position: refs/heads/master@{#319964}
5 years, 9 months ago (2015-03-10 20:49:40 UTC) #36
Lei Zhang
5 years, 9 months ago (2015-03-10 23:22:15 UTC) #38
Message was sent while issue was closed.
Drive by: shouldn't the components/components_tests.gyp change have been applied
to components/BUILD.gn as well?

Powered by Google App Engine
This is Rietveld 408576698